Skip to content

Replace magic number with GRASS_PATTERN_WIDTH constant #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atarukun merged 2 commits into from
Oct 29, 2025
Merged

Replace magic number with GRASS_PATTERN_WIDTH constant #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f4d16
Initial plan
Copilot Oct 29, 2025
ffb852e
Define GRASS_PATTERN_WIDTH constant to replace magic number
Copilot Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions badge/apps/jungle/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
OBSTACLE_SPAWN_MAX = 120
OBSTACLE_REMOVAL_THRESHOLD = -50 # X position at which off-screen obstacles are removed
AIR_GAP = 8 # Vertical gap above ground that the branch bottom sits at (duck to clear)
GRASS_PATTERN_WIDTH = 8 # Width of the repeating grass pattern

# Collision box adjustments for forgiving gameplay
COLLISION_MARGIN = 2 # Pixels reduced from each side of collision boxes
Expand Down Expand Up @@ -222,8 +223,8 @@ def draw_game():

# Draw grass pattern on ground
screen.brush = GRASS_COLOR
for i in range(0, WIDTH, 8):
offset = (state["scroll_offset"] + i) % 8
for i in range(0, WIDTH, GRASS_PATTERN_WIDTH):
offset = (state["scroll_offset"] + i) % GRASS_PATTERN_WIDTH
screen.draw(shapes.rectangle(i - offset, GROUND_Y, 4, 2))

# Draw obstacles
Expand Down
Loading