Ignore Sheets with SheetTypes other than GRID#18
Open
jasonflorentino wants to merge 1 commit into
Open
Conversation
Hi... first time ever forking/pull requesting/contributing/etc. Feel free to ignore or make this fix elsewhere... I ran into errors when trying to work on Spreadsheets containing sheets other than Grids. (In my case, I was trying to work on Spreadsheets that has charts as their own sheets -- an OBJECT type from checking the Sheets API doc.) I've added a line that ensures new Sheet objects (upon first setting up the Sheets inside Spreadsheet, i think) are only created from GRID SheetTypes, as the other refresh functions that run anyway work on attributes not found in other types, ergo the errors (based on my understanding of the program). Adding this check cleared everything up for me. Hopefully it's a solid fix (for now, so long as we're holding off support for other sheetTypes) and doesn't cause issues elsewhere. Thanks, –J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi... first time ever forking/pull requesting/contributing/etc.
Feel free to ignore or make this fix elsewhere...
I ran into errors when trying to work on Spreadsheets containing sheets other than Grids. (In my case, I was trying to work on Spreadsheets that has charts as their own sheets -- an OBJECT type from checking the Sheets API doc.)
I've added a line that ensures new Sheet objects (upon first setting up the Sheets inside Spreadsheet, i think) are only created from GRID SheetTypes, as the other refresh functions that run anyway work on attributes not found in other types, ergo the errors (based on my understanding of the program).
Adding this check cleared everything up for me. Hopefully it's a solid fix (for now, so long as we're holding off support for other sheetTypes) and doesn't cause issues elsewhere. Thanks, –J