Skip to content

docs: fix undefined parameters in README code examples #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asulwer merged 1 commit into from
Jun 27, 2026
Merged

docs: fix undefined parameters in README code examples #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ var workflow = new Workflow
}
};

workflow.Compile(parameters);
var results = workflow.Execute(parameters);
// Compile with type-only parameters (no values needed at compile time)
workflow.Compile(new[] { new RuleParameter("customer", typeof(Customer)) });

// Execute with real data
var customer = new Customer { Age = 25 };
var results = workflow.Execute(new RuleParameter("customer", typeof(Customer), customer));
```

| Instead of... | RoslynRules does... |
Expand Down Expand Up @@ -185,7 +189,7 @@ JIT-only APIs throw `AotCompatibilityException` when called in AOT/trimming mode
```csharp
// This throws in AOT — compile in JIT instead
try {
workflow.Compile(parameters);
workflow.Compile(new[] { new RuleParameter("customer", typeof(Customer)) });
}
catch (AotCompatibilityException ex) {
// Message: "'Workflow.Compile' is not available in AOT/trimming mode..."
Expand Down
Loading