Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/run-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
astropy-version: [4.1.*]
python-version: [3.7]
numpy-version: [1.17.4]
python-version: [3.11]

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -25,10 +23,8 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install "numpy==$NUMPY_VERSION"
python -m pip install "astropy==$ASTROPY_VERSION"
# Non declared build dependencies
python -m pip install Cython
python -m pip install Cython numpy
# Tools to benchmark
python -m pip install -r requirements.txt
# Prefetch as workaround for https://github.com/skyfielders/python-skyfield/issues/262
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
.pydevproject
.settings
.idea
.vscode
*.html
*.pyc
*~
Expand Down
47 changes: 0 additions & 47 deletions coordinates_benchmark/tools/kapteyn.py

This file was deleted.

53 changes: 0 additions & 53 deletions coordinates_benchmark/tools/pyslalib.py

This file was deleted.

60 changes: 0 additions & 60 deletions coordinates_benchmark/tools/pytpm.py

This file was deleted.

4 changes: 2 additions & 2 deletions coordinates_benchmark/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
for _ in CELESTIAL_CONVERSIONS
if _[0] != _[1]]

TOOLS = sorted('astropy kapteyn novas pyast palpy pyephem pyslalib pytpm skyfield'.split())
TOOLS = sorted('astropy novas pyast palpy pyephem skyfield'.split())
TOOL_PAIRS = [_ for _ in itertools.product(TOOLS, TOOLS)
if _[0] < _[1]]

Expand Down Expand Up @@ -136,7 +136,7 @@ def celestial_results(tool, systems, symmetric=False):

# TODO: switch internally to radians and get rid of this helper function!
def angular_separation_deg_to_arcsec(lon1, lat1, lon2, lat2):
from astropy.coordinates.angle_utilities import angular_separation
from astropy.coordinates import angular_separation
from astropy.coordinates import Angle
lon1 = np.radians(lon1)
lat1 = np.radians(lat1)
Expand Down
31 changes: 0 additions & 31 deletions docs/Tools.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ astropy.coordinates
`astropy.coordinates <http://astropy.readthedocs.org/en/latest/coordinates/>`_:
Uses `erfa <https://github.com/liberfa/erfa>`_ for some computations, but re-implements many things using Python / numpy.

kapteyn.celestial
+++++++++++++++++

`kapteyn.celestial <http://www.astro.rug.nl/software/kapteyn/celestial.html>`_:
Part of the `Kapteyn <http://www.astro.rug.nl/software/kapteyn/>`_ package.

NOVAS
+++++

Expand Down Expand Up @@ -51,26 +45,6 @@ PyEphem
`xephem <http://www.clearskyinstitute.com/xephem/>`_ coordinate routines,
which are interfaced as C extensions. Currently a re-write using Cython is underway in the `version4` branch on github.

PySlalib
++++++++

`pyslalib <https://github.com/scottransom/pyslalib>`_

`f2py <http://www.scipy.org/F2py>`_ and `numpy <http://numpy.scipy.org/>`_
wrappers of the fortran version of the astro library `SLALIB <http://www.starlink.rl.ac.uk/docs/sun67.htx/sun67.html>`_

PyTPM
+++++

`pytpm <http://phn.github.com/pytpm/>`_ is `Cython <http://cython.org>`_ interface to the
`TPM <http://www.sal.wisc.edu/~jwp/astro/tpm/tpm.html>`_ C library with a high-level
``convert.convertv6`` function interface. Unmaintained.

We are using the version from github main.

Note that ``pytpm`` is unmaintained and is known to give incorrect results in this case:
https://github.com/phn/pytpm/issues/2

Licenses and Features
---------------------

Expand All @@ -84,14 +58,11 @@ Licenses and Features
Package License Lib License Array Alt/Az
================= ============= ============= ===== ======
astropy BSD --- No No
kapteyn.celestial BSD --- Yes No
novas Public Domain Public Domain No Yes
palpy GPL GPL Some Yes
pyast LGPL LGPL Yes Yes
pyephem LGPL LGPL No Yes
pyslalib GPL GPL No Yes
pysofa MIT SOFA No Yes
pytpm BSD ??? No Yes
================= ============= ============= ===== ======

Notes:
Expand All @@ -100,8 +71,6 @@ Notes:

Please report any inaccuracies, especially concerning the license status.

The following packages have been removed from the ``coordinates-benchmark``:

Other tools that are currently not included
+++++++++++++++++++++++++++++++++++++++++++

Expand Down
4 changes: 0 additions & 4 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
https://github.com/astrojuanlu/pytpm/archive/master.zip; python_version >= "3"
git+http://github.com/astropy/astropy.git#egg=astropy
novas
pyephem
https://github.com/scottransom/pyslalib/archive/master.zip
starlink-pyast
palpy
kapteyn<=2.3; python_version < "3"
http://www.astro.rug.nl/software/kapteyn/kapteyn-3.0.tar.gz; python_version >= "3"
skyfield
click
matplotlib