rest_api/external_interaction/attended_transfer: Add delay to end of referer scenarios.#144
Merged
github-actions[bot] merged 1 commit intoJun 22, 2026
Conversation
…referer scenarios. In these tests, the referer scenarios are 3pcc masters and the referee scenarios are 3pcc slaves. If the master ends before the slave, the slave will fail and cause the test to fail even though it actually passed. Normally, Asterisk sends a BYE to the referee first, then the master which is fine but occasionally, it sends the BYE to the master first which causes the error. Adding a delay to the end of the referer script ensures that even if it receives the BYE first, it won't end before the referee. The test case kills the scenarios in the correct order so in practice, the added delay doesn't actually add overall elapsed time to the test.
Member
Author
|
cherry-pick-to: 20 |
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow Check completed successfully |
Member
Author
|
FYI... I ran 100 iterations of the 8 tests in rest_api/external_interaction/attended_transfer without a single failure. Before this fix, I could never get beyond 50. |
github-actions
Bot
added
cherry-pick-testing-in-progress
|
Workflow CPCheck completed successfully |
jcolp
approved these changes
Jun 22, 2026
github-actions
Bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["20","21","22","23","certified/20.7","certified/22.8"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In these tests, the referer scenarios are 3pcc masters and the referee scenarios
are 3pcc slaves. If the master ends before the slave, the slave will fail
and cause the test to fail even though it actually passed. Normally, Asterisk sends
a BYE to the referee first, then the master which is fine but occasionally, it sends
the BYE to the master first which causes the error. Adding a delay to the end of
the referer script ensures that even if it receives the BYE first, it won't end before
the referee. The test case kills the scenarios in the correct order so in practice,
the added delay doesn't actually add overall elapsed time to the test.