fix-rollbar (7610/464998512971): Fix HealthPermissionsRationaleActivity crash due to action bar theme conflict#612
Open
astashovai wants to merge 1 commit into
Conversation
…ty crash due to action bar theme conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IllegalStateExceptioncrash inHealthPermissionsRationaleActivityon AndroidAppCompatThemeparent fromTheme.AppCompat.Light.DarkActionBartoTheme.AppCompat.Light.NoActionBarRollbar
https://app.rollbar.com/a/astashov/fix/item/liftosaur/7610/occurrence/464998512971
Decision
Fixed — this is a real crash affecting users who open the Health Connect permissions rationale screen on Android.
Root Cause
The
AppCompatThemestyle usedTheme.AppCompat.Light.DarkActionBaras its parent, which provides a window-decor action bar. However,HealthPermissionsRationaleActivity.onCreate()also callssetSupportActionBar(toolbar)with aToolbarwidget from the layout. Android throwsIllegalStateExceptionbecause you cannot set a support action bar when the theme already supplies one via the window decor. The fix is to useNoActionBaras the parent theme so the customToolbarwidget is used instead.Test plan