feat(rl): add renewable strategy compatible with shared MATD3 critics - #811
Open
isaac-gumbrell wants to merge 4 commits into
Open
feat(rl): add renewable strategy compatible with shared MATD3 critics#811isaac-gumbrell wants to merge 4 commits into
isaac-gumbrell wants to merge 4 commits into
Conversation
added 3 commits
May 25, 2026 11:09
… bias RenewableEnergyLearningCompatibleStrategy changes: - Override calculate_bids: remap [-1,1] to [0, max_bid_price] to prevent negative bids that are meaningless for near-zero marginal cost renewables - Override get_actions: bypass EnergyLearningStrategy marginal cost exploration bias by calling TorchLearningStrategy directly, since marginal cost was removed from this strategy's observation space - Remove regret term from calculate_reward: near-zero marginal cost collapses the opportunity cost formula into a one-directional incentive to bid at the floor; profit-only reward provides correct signal
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 80.51% 80.01% -0.50%
==========================================
Files 56 56
Lines 9056 9121 +65
==========================================
+ Hits 7291 7298 +7
- Misses 1765 1823 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kim-mskw
self-requested a review
May 27, 2026 08:39
…n compatibility RenewableEnergyLearningCompatibleStrategy.__init__ unconditionally discarded any caller-provided unique_obs_dim and forced it to 2. When wrapped by _CongestionObsMixin (which inflates unique_obs_dim to 2 + n_lines * congestion_foresight so the centralised critic computes obs_dim correctly), this reset caused the renewable-compatible congestion variant to report obs_dim=74 while sibling generator/storage congestion strategies reported 121, tripping the all-equal check in MATD3.check_strategy_dimensions. Default to 2 but accept overrides from kwargs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a renewable learning strategy that is compatible with the observation dimensions used by the existing generator and storage learning strategies.
The main motivation is mixed-agent RL training. The new strategy keeps renewable units dimension-compatible with the other learning agents so they can share a centralized MATD3 critic. In addition, it adjusts the renewable-specific bidding and reward logic to avoid pathological floor-seeking behaviour and persistent negative-price bidding which result in negative prices.
Changes in this PR:
RenewableEnergyLearningCompatibleStrategyChecklist
docfolder updates etc.)