fix(nextjs): add missing dependencies in nextjs_standalone_server#2890
Merged
Conversation
Adds a server_test to examples/nextjs that starts the standalone server binary and polls for an HTTP response, catching potential regressions where the build succeeds but the server fails to run. This turned up some issues where we had some missing dependencies. These would not necessarily be easy to catch with manual testing, since "bazel run" does not use a sandbox and can therefore succeed even when important dependencies are absent. The most important thing was making sure the `js_binary` takes a dependency on the actual sources produced by `next build`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jbedard
reviewed
Jun 15, 2026
acozzette
changed the title
acozzette
changed the title
jbedard
reviewed
Jun 15, 2026
jbedard
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a server_test to examples/nextjs that starts the standalone server binary and polls for an HTTP response, catching potential regressions where the build succeeds but the server fails to run.
This turned up some issues where we had some missing dependencies. These would not necessarily be easy to catch with manual testing, since "bazel run" does not use a sandbox and can therefore succeed even when important dependencies are absent. The most important thing was making sure the
js_binarytakes a dependency on the actual sources produced bynext build.Changes are visible to end-users: yes
Fix handling of dependencies in nextjs_standalone_server()
Test plan