Skip to content

test: enable runfiles tree on Windows for e2e/bzlmod#2886

Merged
jbedard merged 1 commit into
aspect-build:mainfrom
jbedard:bcr-windows
Jun 11, 2026
Merged

test: enable runfiles tree on Windows for e2e/bzlmod#2886
jbedard merged 1 commit into
aspect-build:mainfrom
jbedard:bcr-windows

Conversation

@jbedard

@jbedard jbedard commented Jun 11, 2026

Copy link
Copy Markdown
Member

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from acozzette June 11, 2026 18:54
@jbedard

jbedard commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

@jbedard jbedard enabled auto-merge (squash) June 11, 2026 18:57
@acozzette

Copy link
Copy Markdown
Contributor

Should we be adding support for the runfiles library to the launcher script so that the Windows tests can run normally without this flag? I have a change in progress that does that. I set it aside because it was built on top of the $(rlocation) idea that we are probably not going to go with. But I could fix it to work without that.

@jbedard jbedard merged commit d50ae1f into aspect-build:main Jun 11, 2026
155 checks passed
@jbedard jbedard deleted the bcr-windows branch June 11, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants