feat: Support hermetic patching#1453
Conversation
45a8736 to
eaee6f2
Compare
eaee6f2 to
ab6f793
Compare
|
@gregmagolan Just wanted to gauge if there's any interest in this feature? I know Windows is a lesser used platform, but I'm sure there's teams out there (like mine) who would find this useful. |
|
@gregmagolan any thoughts on this MR? I tried to run a rules_js project on Windows, and it blew up while resolving NPM packages due to the "patch" dependency. |
|
Ran into this issue as well on our Macs which have an older version of |
|
|
Allows Bazel native patch to be used with npm_import(). This removes the existing dependency on patch when enabled. The proviso is that patch diff headers must have an unstripped 'package/' prefix when use_native_patch is true. The dirname 'package' is the de facto standard for npm packages, though this isn't enforced.
Type of change
For changes visible to end-users
Suggested release notes are provided below:
Test plan
Manual testing steps: