Use Google Drive AppData folder instead of cluttering GDrive#9
Open
cfunkhouser wants to merge 2 commits into
Open
Use Google Drive AppData folder instead of cluttering GDrive#9cfunkhouser wants to merge 2 commits into
cfunkhouser wants to merge 2 commits into
Conversation
If either the ChunkParentID or FileParentID options are not specified, the files which would have been written to those directories is instead written to the hidden app data directory. The result is an uncluttered Google Drive file list. Data stored this way can be wholesale deleted from the "Settings" pane.
asjoyner
requested changes
Apr 28, 2018
asjoyner
left a comment
asjoyner
left a comment
Owner
There was a problem hiding this comment.
Thanks for the CL! There's just one regression...
| q = fmt.Sprintf("%s and ('%s' in parents OR '%s' in parents)", q, s.config.FileParentID, s.config.ChunkParentID) | ||
| spaces := "appDataFolder" | ||
| if s.config.ChunkParentID != "" { | ||
| q = fmt.Sprintf("%s and '%s' in parents", q, s.config.ChunkParentID) |
Owner
There was a problem hiding this comment.
You're removing the OR that also looks in s.config.FileParentId. That doesn't work for the non-appDataFolder case, because GetFile calls through to GetChunk, so GetChunk needs to look in both places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When either
FileParentIDorChunkParentIDare omitted from a Google Drive configuration, store those files in the hidden app data folder instead. The app data folder is not manageable through the Google Drive web interface (except to wholesale delete all app data), so shade storage will not clutter the Google Drive file manager interface.