Visibility Filter#1
Open
ashleyjlive wants to merge 10 commits into
Open
Conversation
racing.proto: • Add optional `visible` parameter to ListRacesRequestFilter. races.proto: • Use optional visibility filter parameter to filter returned dataset.
• Provide description of `visible` request filter.
• Added basic test case for filtering with visibility. db.go: • Allow for clearing and insertion of database records. races.go: • Added `InsertRace` and `Clear` to RacesRepo interface for testing purposes.
• Implement ListAll without filter for test cases. • Disable automatic seeding. races_test: • Refined database and repo initialisation. • Added tests for fetching empty repos and repo insertion.
Owner
Author
|
Please note that I added some additional interface functions for implementing |
• Added README.md file. racing/README.md: • Added link to proto/README.md
• Fixed invalid testType of "db" for races_test.
• Added seeding as an optional start argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow for visibility field to be included in filter when retrieving race list.
Reason
In some instances, only showing visible events may be useful.