feat: marketplace plugin + pluggable reviewer (hook v4)#9
Merged
Conversation
… (T026a); fix US4 priority P4→P2
…US1) - .claude-plugin/plugin.json (wingman v1.0.0) + marketplace.json (single-repo) - claude plugin validate --strict passes - README leads with write-back wedge; dual install (plugin + skills CLI); WINGMAN_REVIEWER documented Implements FR-001,002,003,013,016(doc); US1.
…US4/US5) - WINGMAN_REVIEWER=codex|gemini|claude; codex path unchanged; gemini/claude get constructed diff+prompt (uniform [P1/P2/P3] contract) via stdin (ARG_MAX-safe) - per-reviewer metadata; reviewer.tool from WINGMAN_TOOL - reviewer_missing record when CLI absent/unknown (push never blocked) - [CROSS-MODEL NOTE] when reviewer=claude (FR-017) - resolution: env > .wingman-reviewer file > codex; setup persists default - hook v3->v4 (marker unchanged → auto-upgrade); install.sh message generalized - skills de-Codex'd; CI smoke: v1/v2/v3->v4 (+data-preservation), reviewer_missing, reviewer.tool - all install-smoke scenarios green; shellcheck/bash -n/py_compile clean Implements FR-004,005,006,007,008,009,010,011,012,016,017,018; US2-US5.
…ng, drop stray sample (US8/FR-014,019)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages Wingman as a Claude Code marketplace plugin and makes the reviewer genuinely pluggable. Built spec-kit-driven (
specs/001-marketplace-plugin-reviewer/): specify → clarify → plan → tasks → analyze → implement.What
.claude-plugin/plugin.json(wingman v1.0.0) + single-repomarketplace.json. Installable via/plugin marketplace add ashbrener/wingman→/plugin install wingman. Skills auto-discovered as/wingman:*.npx skills addpath retained. (US1)WINGMAN_REVIEWER= codex (default) | gemini | claude. Codex path byte-for-byte unchanged; gemini/claude get a constructed diff+prompt with a uniform[P1/P2/P3]output contract piped via stdin (ARG_MAX-safe). Per-reviewer metadata (reviewer.tool/model/provider). Resolution: env var →.wingman-reviewerfile → codex. (US2)reviewer_missingrecord; push never blocked. Same-model (claude) runs with a non-blocking[CROSS-MODEL NOTE]. (US3, FR-017).reviews/data. (US4)WINGMAN_REVIEWER). (US2/US5)Verification
claude plugin validate . --strict✔bash -n+py_compile(both heredocs) ✔install-smokelocally green: fresh / v1→v4 / v2→v4 / v3→v4 (+ data-preservation) / --force / exemptions / convergence / reviewer_missing / reviewer.tool ✔Notes
wingman_schema_version: "3"(addsreviewer_missingstatus;reviewer.toolnow varies).CLAUDE.md, and.envare gitignored — not part of the package.specs/001-marketplace-plugin-reviewer/(the earlierdocs/superpowers/spec/plan are superseded but left for history).