fix(install): cross-platform mktemp + 3 shellcheck warnings#6
Merged
Conversation
PR #5's install-smoke job (Linux runner) caught two `mktemp -t name` invocations that fail on GNU mktemp (`too few X's in template`). Linux/WSL contributors would have hit this immediately. Both fixed to `mktemp -t name.XXXXXX` — portable across BSD (macOS) and GNU. Also clears 3 pre-existing shellcheck warnings PR #5's lint job surfaced in scripts/install.sh: - SC2034: unused END_MARKER - SC2126: grep|wc -l → grep -c - SC2129: grouped redirects with { ... } >> file No version bump (still wingman-hook-version: 2 — bugfixes within v2).
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mktemp -t namecalls inscripts/install.shandassets/pre-push.sample— GNUmktemprejects them (too few X's in template); switched tomktemp -t name.XXXXXXfor BSD+GNU portability.scripts/install.sh: SC2034 (unusedEND_MARKER), SC2126 (grep|wc -l→grep -c), SC2129 (grouped>>redirects with{ ... } >> file).How surfaced
PR #5's CI workflow caught these on first run.
Test plan
bash -nclean on both filesshellcheck --severity=errorcleanshellcheck(default) clean (no SC2034/2126/2129)