fix: Skip embed form standalone validation#473
Closed
sevenseacat wants to merge 2 commits into
Closed
Conversation
Nested forms backed by an embedded attribute/argument were validated
twice: once against the embed's own create/update action, and again
inline when the parent action cast the merged params. The standalone
pass bypasses parent-level logic (e.g. a `cast_input/2` override on
the embed that collapses blank input to `nil`), so an all-blank embed
sub-form produced spurious "is required" errors even when the parent
would have accepted the value as nil.
After validating, clear `source.errors` and mark the source valid for
forms with `embed?: true`. `carry_over_errors/2` replays any real
errors the parent's validation surfaces with a matching path. Forms
with `transform_params` set are skipped — unions rewrite params into
an `%Ash.Union{}` before handing them up, so their standalone
validation is the only line of defense.
`clear_embed_source_errors/2` used `!opts[:transform_params]` to detect union sub-forms. `transform_params` is also a public form option, so a caller setting it on a non-union embed (undocumented but reachable) would silently disable the exemption. Set `union?: true` in `unions/3` and check that instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, there's a bit of a gap in how AshPhoenix treats forms for embedded resources vs. related resources - embedded resources really shouldn't be validated separately, their validation is done via the parent form.
The edge cases is for union types - there are existing tests verifying the expected behaviour for unions, and they continue to pass.
Contributor checklist
Leave anything that you believe does not apply unchecked.