Remove Help Page / Fix CI - #3
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the Help page link from the Admin Panel sidebar and restructures GitHub Actions so that builds run on pushes to main, while deployments are triggered manually.
Changes:
- Commented out the
/helpnavigation item in the sidebar. - Split the prior push-triggered deploy workflow into:
build.yaml(push-triggered tests + build + push to ECR)deploy.yaml(manual deploy, with animage_taginput)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/components/Sidebar.tsx |
Removes the Help entry from the navigation items (currently via commenting it out). |
.github/workflows/deploy.yaml |
Converts deploy to manual-only and adds image_tag input to deploy a chosen image tag. |
.github/workflows/build.yaml |
Adds a push-to-main workflow to run tests and build/push the Docker image to ECR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Update image on EKS | ||
| run: | | ||
| kubectl set image deploy/${{ env.DEPLOYMENT_NAME }} \ | ||
| jarvis-admin-panel=${{ needs.build-and-push.outputs.image }} \ | ||
| jarvis-admin-panel=${{ steps.login-ecr.outputs.registry }}/jarvis/admin-panel:${{ inputs.image_tag }} \ | ||
| -n ${{ inputs.application }} |
| - name: Assume IAM role | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: ${{ secrets.SAAS_AWS_DEPLOY_ROLE_ARN }} | ||
| role-session-name: deployment-role-session | ||
| aws-region: us-east-1 |
There was a problem hiding this comment.
Good catch. Will lock the deploy region to us-east-1
daochidq
left a comment
daochidq
left a comment
There was a problem hiding this comment.
Is there any specific reason to separate into two
No there isn’t. I originally configured the pipelines to run on push, causing some inputs to be empty. Breaking them into two pipelines was the wrong fix. I’ve consolidated into 1 pipeline that is manually triggered (same pattern as other repos) |
HelpPage from Sidebar navigations