ci: bump Node to 22 so npm@latest can publish#69
Conversation
Node 20 is EOL and npm@latest (v12) requires Node >=22.22.2 || >=24.15.0 || >=26, breaking the 'Upgrade npm for trusted publishing' step in the publish job. Bump both jobs to Node 22, which satisfies the packages' engines (>=20.0.0).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow's Node.js setup steps for both the test and publish jobs are updated to use version 22 instead of version 20. No other workflow structure, triggers, or steps are changed. ChangesCI Node Version Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes the failing
publishjob onmain(CI run 29027484029).The
Upgrade npm for trusted publishingstep runsnpm install -g npm@latest, which now resolves to npm@12. npm 12 requires Node^22.22.2 || ^24.15.0 || >=26, but the workflow runs on Node 20 (now EOL), so the step fails withEBADENGINEand the packages are never published.Change
Bump both CI jobs (
testandpublish) from Node 20 → Node 22. This satisfies npm@latest and stays within the packages'engines(node >=20.0.0).Impact
The publish job is idempotent (
npm view ... && skip), so once this merges it will publish the versions that failed to go out from #68:@arvoretech/hub-core0.26.2@arvoretech/hub(cli) 0.25.2@arvoretech/hub-pi1.5.3What was tested
Workflow-only change. The
testjob (lint + test + build) will re-run on Node 22 in this PR's CI.Summary by CodeRabbit