Skip to content

ci: bump Node to 22 so npm@latest can publish#69

Merged
ricardoraposo merged 1 commit into
mainfrom
ricardo-/-ci-node22-fix-publish
Jul 9, 2026
Merged

ci: bump Node to 22 so npm@latest can publish#69
ricardoraposo merged 1 commit into
mainfrom
ricardo-/-ci-node22-fix-publish

Conversation

@ricardoraposo

@ricardoraposo ricardoraposo commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes the failing publish job on main (CI run 29027484029).

The Upgrade npm for trusted publishing step runs npm install -g npm@latest, which now resolves to npm@12. npm 12 requires Node ^22.22.2 || ^24.15.0 || >=26, but the workflow runs on Node 20 (now EOL), so the step fails with EBADENGINE and the packages are never published.

npm error code EBADENGINE
npm error Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"}
npm error Actual:   {"npm":"10.8.2","node":"v20.20.2"}

Change

Bump both CI jobs (test and publish) from Node 20 → Node 22. This satisfies npm@latest and stays within the packages' engines (node >=20.0.0).

Impact

The publish job is idempotent (npm view ... && skip), so once this merges it will publish the versions that failed to go out from #68:

  • @arvoretech/hub-core 0.26.2
  • @arvoretech/hub (cli) 0.25.2
  • @arvoretech/hub-pi 1.5.3

What was tested

Workflow-only change. The test job (lint + test + build) will re-run on Node 22 in this PR's CI.

Summary by CodeRabbit

  • Chores
    • Updated the build and release pipeline to use Node.js 22 instead of Node.js 20.

Node 20 is EOL and npm@latest (v12) requires Node >=22.22.2 || >=24.15.0
|| >=26, breaking the 'Upgrade npm for trusted publishing' step in the
publish job. Bump both jobs to Node 22, which satisfies the packages'
engines (>=20.0.0).
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
rhm-website Ready Ready Preview, Comment Jul 9, 2026 3:36pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 622db7b1-bc2c-4eab-9fef-c2f25ddc984f

📥 Commits

Reviewing files that changed from the base of the PR and between a7b1afa and 3212395.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow's Node.js setup steps for both the test and publish jobs are updated to use version 22 instead of version 20. No other workflow structure, triggers, or steps are changed.

Changes

CI Node Version Update

Layer / File(s) Summary
Update Node.js version in CI jobs
.github/workflows/ci.yml
Both the test and publish jobs' Node.js setup steps now use node-version: "22" instead of "20".

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: rafaelandrade

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: bumping CI Node.js to 22 to support npm@latest publishing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ricardo-/-ci-node22-fix-publish

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ricardoraposo
ricardoraposo merged commit ae873df into main Jul 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant