Skip to content

Fix mixture #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aloctavodia merged 2 commits into from
Jun 7, 2026
Merged

Fix mixture #722

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92832b2
fix mixture
aloctavodia Jun 7, 2026
9ae1414
fix variable name
aloctavodia Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions preliz/distributions/mixture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import numpy as np
from scipy.special import logsumexp

from preliz.distributions.distributions import DistributionTransformer
from preliz.internal.distribution_helper import all_not_none, num_kurtosis, num_skewness
Expand Down Expand Up @@ -87,17 +88,21 @@ def ppf(self, q):
return find_ppf(self, q)

def logpdf(self, x):
return np.sum(
[dist.logpdf(x) * weight for dist, weight in zip(self.dist, self.weights)], axis=0
log_terms = np.array(
[np.log(weight) + dist.logpdf(x) for dist, weight in zip(self.dist, self.weights)]
)
return logsumexp(log_terms, axis=0)

def entropy(self):
x_values = self.xvals("restricted")
logpdf = self.logpdf(x_values)
with np.errstate(divide="ignore", invalid="ignore"):
weighted_logpdf = np.exp(logpdf) * logpdf
weighted_logpdf = np.where(np.isfinite(weighted_logpdf), weighted_logpdf, 0.0)
if self.kind == "discrete":
return -np.sum(np.exp(logpdf) * logpdf)
return -np.sum(weighted_logpdf)
else:
return -np.trapzoid(np.exp(logpdf) * logpdf, x_values)
return -np.trapezoid(weighted_logpdf, x_values)

def mean(self):
return np.sum(
Expand Down
Loading