π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Audit Detail JSON rendering#482
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Audit Detail JSON rendering#482arumes31 wants to merge 1 commit into
Conversation
- Fixed DOM-based Cross-Site Scripting (XSS) vulnerability in `templates/management.html` and `templates/profile.html`. - Swapped unsafe `.innerHTML` interpolation of `JSON.stringify` data with safe `.textContent` assignment. - This prevents execution of unescaped HTML tags embedded in JSON properties (like User-Agent headers). Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: HIGH
π‘ Vulnerability: The frontend interpolates
JSON.stringifydirectly intoinnerHTMLstrings when rendering audit log details.π― Impact: This causes an XSS vulnerability, as the
detailsJsoncan contain arbitrary data (like User-Agent headers) that will be executed as HTML/JS if it contains HTML tags.π§ Fix: Updated
showAuditDetailto safely inject the JSON string by creating a<pre>element and setting its.textContentproperty, preventing HTML tag execution.β Verification: Review the frontend logic modifications and run standard test suites.
PR created automatically by Jules for task 11134929976799648942 started by @arumes31