Skip to content

Add continue reading link#42

Open
amorphic wants to merge 3 commits into
arulrajnet:masterfrom
amorphic:add_continue_reading
Open

Add continue reading link#42
amorphic wants to merge 3 commits into
arulrajnet:masterfrom
amorphic:add_continue_reading

Conversation

@amorphic

@amorphic amorphic commented Jan 2, 2019

Copy link
Copy Markdown

This PR:

  1. Adds a "Continue Reading" link at the bottom of each article's summary. This allows the reader to click directly through to the full article from the end of the summary rather than scroll back up to the Headline. The link is styled using the same "button" style as the article tags.

  2. Updates the "Comments" link to the same style as the "Continue Reading" link and places them side-by-side to conserve vertical space:

image

@arulrajnet

Copy link
Copy Markdown
Owner

@amorphic Thanks for your PR. The buttons are not properly formatted when I tried with attila-demo source code
image

@amorphic amorphic force-pushed the add_continue_reading branch from 7ca0e46 to ecd2d12 Compare January 6, 2019 03:39
@amorphic

amorphic commented Jan 6, 2019

Copy link
Copy Markdown
Author

Thanks for checking @arulrajnet. The buttons render correctly on my blog so I assumed they were good to go.

I'll looking into what's going wrong with the attila demo blog and update the PR accordingly.

1 similar comment
@amorphic

amorphic commented Jan 9, 2019

Copy link
Copy Markdown
Author

Thanks for checking @arulrajnet. The buttons render correctly on my blog so I assumed they were good to go.

I'll looking into what's going wrong with the attila demo blog and update the PR accordingly.

Allows a reader to click directly through to the article from the
end of the summary.
@amorphic amorphic force-pushed the add_continue_reading branch from ecd2d12 to 477a5db Compare January 13, 2019 01:17
@amorphic

Copy link
Copy Markdown
Author

@arulrajnet I've updated the PR and tested against my blog and the Attila demo site:

image

The change is actually much cleaner since the update too. Please let me know if you want any other changes.

@sio

sio commented Jul 31, 2019

Copy link
Copy Markdown
Contributor

Are these links optional? I'd like to have the ability to opt out of rendering them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants