Exposing PodLabels, PodAnnotations, and Tolerations on Deployment#139
Draft
onelapahead wants to merge 4 commits into
Draft
Exposing PodLabels, PodAnnotations, and Tolerations on Deployment#139onelapahead wants to merge 4 commits into
onelapahead wants to merge 4 commits into
Conversation
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io> Made-with: Cursor
Adds podAnnotations support for Deployment resources. Static annotations
from the source manifest are preserved, with a values-driven merge block
appended so users can inject additional annotations at install/upgrade
time without re-generating the chart.
Also seeds podAnnotations: {} in values.yaml by default, consistent with
the existing podLabels field.
Closes arttor#119
Made-with: Cursor
onelapahead
force-pushed
the
pod-settings
branch
2 times, most recently
from
d7462ac to
6fc4890
Compare
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meant to close #119 . Need to add
podAnnotationssupport and do some more testing before considering this ready.Believe bc
tolerationsis in the pod spec it works for more than just deployments. So will have consider adding thepodLabelsandpodAnnotationssupport to daemonsets, etc. and moving it to a more common place.