chore: cleanup sale ff#13661
Merged
Merged
Conversation
Assisted-By: Claude <noreply@anthropic.com>
araujobarret
previously approved these changes
Jun 17, 2026
araujobarret
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Idk if we still create PRs to Echo to mark when the FF was retired, but this is enough on Eigen's side, thanks for pushing it 👍
gkartalis
previously approved these changes
Jun 17, 2026
a366265
Contributor
Contributor
Author
i think we might as well keep it up, would be nice to go through and mark old ones as retired at some point, and then we might actually be able to shrink this json at some point 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
This feature flag has been out a while now and we should be okay to remove. Can remove quite a bit of legacy code with this gone.
UX is the same as previous.
android-sale-low.mov
ios-sale-low.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.