Conversation
Sam-Sims
approved these changes
Dec 5, 2025
Collaborator
Sam-Sims
left a comment
Sam-Sims
left a comment
There was a problem hiding this comment.
LGTM - possibly want to re-enable the RNA bloom test, at least in CI despite the issues running locally on ARM
Member
Author
|
The logic behind the rnabloom commenting is that if I can't run the tests locally I can't update snapshots where necessary so it's best for it to be removed, it's also not mission critical functionality so I'm less worried about it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further Q score mean calculation speedup