Fixed V2 integration for entering trades on the function: "place_order"#22
Open
BrianWeiss1 wants to merge 4 commits into
Open
Fixed V2 integration for entering trades on the function: "place_order"#22BrianWeiss1 wants to merge 4 commits into
BrianWeiss1 wants to merge 4 commits into
Conversation
caelum24
reviewed
Jun 22, 2026
caelum24
left a comment
There was a problem hiding this comment.
Only the post requests had /events/ added to them for V2 it seems. Getting orders should still be just fine without the update
Author
|
Also the request input changed, the order data dictionary should look like this now: |
Author
|
but yes, getting orders should still be correct. Just placing orders fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.