added timeline to resource page#6
Open
arpit2006 wants to merge 1 commit into
Open
Conversation
Signed-off-by: arpit2006 <arpitshirbhate25@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe "Current Skills" field in ChangesInteractive Skill Selector
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@views/profile-setup.ejs`:
- Around line 99-160: The skill badges in the profile setup view are implemented
as clickable spans, and the existing toggle logic in the profile setup script
only handles pointer clicks, so keyboard users cannot activate them. Update the
skill toggle UI in profile-setup.ejs to use keyboard-accessible controls or add
proper button/ARIA semantics, and extend the handler in the skill toggle logic
(the block that manages .skill-tag-badge clicks) to support Enter/Space
activation and focus states while keeping the selected skill state in sync.
- Around line 234-255: The custom-skill add flow in the profile setup script
only checks selectedSkills, so it can still create a duplicate of an existing
predefined skill like Python when that tag is not already selected. Update the
validation in the custom skill handler around selectedSkills, updateSkillsInput,
and the custom-skills-group badge creation to also compare against the full
predefined skills list currently used to render tags, and block adding the
custom badge/input when a case-insensitive match already exists anywhere in the
predefined options.
In `@views/profile.ejs`:
- Around line 283-304: The custom skill add flow in the profile view only checks
`selectedSkills`, so a name that already exists as a predefined skill can still
be inserted as a custom badge and get out of sync with toggle state. Update the
custom-skill handling logic to also compare against the predefined skill list
before creating the badge, and route matching names through the existing
predefined selection/toggle path instead of appending them to the custom group.
Keep the fix in the same client-side block that updates `selectedSkills`,
`updateSkillsInput()`, and the `custom-skills-group` badge creation.
- Around line 124-200: The skill chips in profile edit are clickable-only
because the interactive elements in the skill categories and custom skills are
rendered as spans and the profile script handling selection only reacts to mouse
clicks. Update the skill toggle UI in profile.ejs and the associated handler
around the skill-selection listener so the same controls can be reached and
activated from the keyboard, using proper focusable semantics and keyboard
events for the existing skill tag behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 2b61e423-c496-44fa-8e76-419f55cd6cda
📒 Files selected for processing (3)
public/css/style.cssviews/profile-setup.ejsviews/profile.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new Personalized Study Planner & Course Completion Timeline feature request to improve the learning experience for users.
What's Added
Added a comprehensive GitHub issue describing the new Study Planner feature.
Proposed a personalized planning workflow where users can generate a study schedule based on their daily or weekly availability.
Included UI/UX suggestions for a planner modal with:
Added technical implementation notes and acceptance criteria to help contributors implement the feature consistently.
Included optional enhancements such as reminders, calendar export, study streaks, and progress analytics.
Why This Change?
Currently, course cards only display the total course duration. This feature proposal aims to help learners:
Related Issue
Closes #<issue_number>
Type of Change
How Has This Been Tested?
Checklist
Summary by CodeRabbit
New Features
Bug Fixes