Update bonds when atoms moved individually#48
Open
cajfisher wants to merge 8 commits into
Open
Conversation
Refreshes bonds in model window when atom coordinates changed in Model:Editing box (same as already done for groups of selected atoms).
Enables reading and writing of structures in xsf format (including animation files)
Fixes bug in file_meta.c when parsing units Replaces deprecated g_pattern_match_string with g_pattern_spec_match_string in file.c Replace QE with Quantum Espresso in file type lists for clarity Correct various spelling/punctuation errors
Collaborator
|
Hello, About the PR:
I will review the XCrysDen file reader later with the other PR. Where MYNAME is.. your name 😆 Best, |
ovhpa
reviewed
Sep 10, 2022
| /* CIF loading */ | ||
| /***************/ | ||
| #define DEBUG_LOAD_CIF 0 | ||
| #define DEBUG_LOAD_CIF 1 |
Collaborator
There was a problem hiding this comment.
DEBUG should be OFF by default, I think.
ovhpa
reviewed
Sep 10, 2022
| /* shouldn't matter when this routine is properly implemented, as we'll go */ | ||
| /* through the atom_list in the usual fashoin & terminate when it is NULL, */ | ||
| /* not when it's data ptr is NULL */ | ||
| /* through the atom_list in the usual fashoin and terminate when it's NULL, */ |
Adds a button to "Region" window of "Model editing" dialog to calculate surface dipole of a 2D model and report it in message box
Some OSs use older versions of glib, before g_pattern_spec_match_string replaced g_pattern_match_string (deprecated since v2.70)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes bonds in model window when atom coordinates changed in Model:Editing box (same as already done for groups of selected atoms).
Also updates dipole in Model:Content box as soon as changes made.