fix(autoconfig): replace existing preset contents - #179
Merged
SuperKali merged 1 commit intoAug 14, 2026
Conversation
|
Thank you, super quick solution :) |
Member
|
Thanks @Guflly i'll check asap. |
SuperKali
approved these changes
Aug 14, 2026
Member
There was a problem hiding this comment.
Tested on a real mke2fs image with /root/.not_logged_in_yet already present: main reproduces #178, this branch writes 382 bytes and validates, partitioned path included. One for later: the freed block never gets cleared in the bitmap, because ext4_bmap_bits_free is called with a count where it expects an end index, so every rewrite leaks one block. resize2fs handles the result fine, we will fix that one on our side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing ext4 files were opened with w+, but the vendored filesystem ignored O_TRUNC. Shorter presets kept the previous tail and failed validation.
This honors truncation on open and adds a regression test for replacing a 420-byte file with 382 bytes.
Closes #178