Skip to content
This repository was archived by the owner on Mar 29, 2026. It is now read-only.

control armbian-common: move armbian-bsp to Suggests#29

Merged
leggewie merged 1 commit into
armbian:mainfrom
tabrisnet:tabrisnet_bsp
Dec 10, 2025
Merged

control armbian-common: move armbian-bsp to Suggests#29
leggewie merged 1 commit into
armbian:mainfrom
tabrisnet:tabrisnet_bsp

Conversation

@tabrisnet

@tabrisnet tabrisnet commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

This has been discussed in #25 & is one [partial?] solution to #28.
Specifically, we cannot pull in armbian-bsp into the rootfs. We want to install it a bit later in the armbian/build image process, and in fact that is already done [no change is needed in armbian/build].

@coderabbitai

coderabbitai Bot commented Dec 8, 2025

Copy link
Copy Markdown

Walkthrough

This change modifies the debian/control file for the armbian-common package. The dependency on armbian-bsp or armbian-bsp-cli (specified as armbian-bsp|armbian-bsp-cli) has been moved from the Depends field to the Suggests field. This transitions the dependency from mandatory to optional, changing the default installation behavior while maintaining the relationship in the package metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification with a straightforward dependency metadata move
  • Verify the dependency identifier was correctly transferred to the Suggests field
  • Confirm debian/control syntax remains valid and no unintended lines were modified
  • Ensure this behavioral change aligns with the package's intended design

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: moving armbian-bsp from Depends to Suggests in the control file for armbian-common.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly relates to the changeset by explaining the rationale for moving armbian-bsp from Depends to Suggests in debian/control.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added 02 Milestone: First quarter release size/small PR with less then 50 lines Needs review Seeking for review and removed size/small PR with less then 50 lines labels Dec 8, 2025
@tabrisnet tabrisnet requested a review from leggewie December 9, 2025 20:09

@leggewie leggewie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that semantically, the dependency is stronger than a mere suggestion but I can see the ramifications of it being in Depends.

Approved, thank you for your help in fixing this and other issues in APA. Much appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

02 Milestone: First quarter release Needs review Seeking for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants