control armbian-common: move armbian-bsp to Suggests#29
Conversation
WalkthroughThis change modifies the debian/control file for the armbian-common package. The dependency on armbian-bsp or armbian-bsp-cli (specified as Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
leggewie
left a comment
There was a problem hiding this comment.
I think that semantically, the dependency is stronger than a mere suggestion but I can see the ramifications of it being in Depends.
Approved, thank you for your help in fixing this and other issues in APA. Much appreciated.
This has been discussed in #25 & is one [partial?] solution to #28.
Specifically, we cannot pull in
armbian-bspinto therootfs. We want to install it a bit later in thearmbian/buildimage process, and in fact that is already done [no change is needed inarmbian/build].