[ATfL] Gradually retire the ability to pass COMMON_CMAKE_FLAGS from the outside#860
[ATfL] Gradually retire the ability to pass COMMON_CMAKE_FLAGS from the outside#860pawosm-arm wants to merge 1 commit into
Conversation
pawosm-arm
requested review from
DavidTruby,
LukeIreland1,
schander-arm and
vrukesh
| ## Configuration: Build ## | ||
| ########################## | ||
|
|
||
| if [[ -n "${COMMON_CMAKE_FLAGS}" ]]; then |
There was a problem hiding this comment.
The commit message says "gradually retire". So shouldn't we first emit a message of deprecation, continue without exiting and then completely remove it in a future release?
There was a problem hiding this comment.
We never recommended to use it in the first place, and I don't remember what circumstances allowed this feature to appear here. The 'gradual retire' effectively means we're looking if something is going to fail (showing the error message) after we introduce this commit.
There was a problem hiding this comment.
Looking at the log:
This will allow us to tweak the CMake configuration.
I can't remember which part of the CMake configuration we wanted to tweak using this hammer, I guess we were facing some problem, and this was one of the measures to address it. I have no idea if this has found any use in our CI, I hope it hasn't.
2 participants
No description provided.