Merge extensions-compose-experimental module into extensions-compose#1008
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
658550d to
7c90b80
Compare
fbbb2f7 to
ca61994
Compare
7c90b80 to
12df5ef
Compare
ca61994 to
08adf12
Compare
08adf12 to
b1335be
Compare
b1335be to
c19de5b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@extensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/panels/ChildPanels.kt`:
- Around line 1-15: The compose documentation imports are still pointing to the
experimental panels APIs, so update the examples to use the stable packages
instead. In the docs section that references ChildPanels and
ChildPanelsAnimators, switch imports from the experimental namespace to
com.arkivanov.decompose.extensions.compose.panels for ChildPanels and
com.arkivanov.decompose.extensions.compose.stack.animation for
ChildPanelsAnimators, matching the current symbols exposed in ChildPanels and
related animation APIs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e469923b-0738-44d2-b496-24a8433dc8a4
📒 Files selected for processing (45)
extensions-compose-experimental/.gitignoreextensions-compose-experimental/api/android/extensions-compose-experimental.apiextensions-compose-experimental/api/extensions-compose-experimental.klib.apiextensions-compose-experimental/api/jvm/extensions-compose-experimental.apiextensions-compose-experimental/build.gradle.ktsextensions-compose-experimental/dependencies/androidReleaseRuntimeClasspath.txtextensions-compose/api/android/extensions-compose.apiextensions-compose/api/extensions-compose.klib.apiextensions-compose/api/jvm/extensions-compose.apiextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/BroadcastBackHandler.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/Utils.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/panels/ChildPanels.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/panels/ChildPanelsAnimators.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/panels/ChildPanelsLayout.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/panels/HorizontalChildPanelsLayout.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/ChildStack.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/SimpleStackAnimationScope.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/Utils.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/DefaultStackAnimation.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/DefaultStackAnimator.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/EmptyStackAnimation.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/Fade.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/PredictiveBackParams.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/Scale.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/Slide.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/StackAnimation.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/StackAnimationProvider.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/StackAnimationScope.ktextensions-compose/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/StackAnimator.ktextensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/TestUtils.ktextensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/Utils.ktextensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/stack/ChildStackTest.ktextensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/DefaultStackAnimationTest.ktextensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/GetFadeAlphaTest.ktextensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/PredictiveBackGestureTest.ktextensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/stack/animation/StackAnimationDirectionsTest.ktsample/shared/compose/build.gradle.ktssample/shared/compose/src/commonMain/kotlin/com/arkivanov/sample/shared/counters/CountersContent.ktsample/shared/compose/src/commonMain/kotlin/com/arkivanov/sample/shared/dynamicfeatures/DynamicFeaturesContent.ktsample/shared/compose/src/commonMain/kotlin/com/arkivanov/sample/shared/dynamicfeatures/dynamicfeature/DynamicFeatureContent.ktsample/shared/compose/src/commonMain/kotlin/com/arkivanov/sample/shared/multipane/MultiPaneContent.ktsample/shared/compose/src/commonMain/kotlin/com/arkivanov/sample/shared/root/RootContent.ktsample/shared/compose/src/commonMain/kotlin/com/arkivanov/sample/shared/sharedtransitions/SharedTransitionsContent.ktsample/shared/compose/src/commonMain/kotlin/com/arkivanov/sample/shared/tabs/TabsContent.ktsettings.gradle.kts
💤 Files with no reviewable changes (9)
- extensions-compose/src/jvmTest/kotlin/com/arkivanov/decompose/extensions/compose/Utils.kt
- extensions-compose-experimental/.gitignore
- extensions-compose-experimental/dependencies/androidReleaseRuntimeClasspath.txt
- extensions-compose-experimental/build.gradle.kts
- sample/shared/compose/build.gradle.kts
- extensions-compose-experimental/api/jvm/extensions-compose-experimental.api
- settings.gradle.kts
- extensions-compose-experimental/api/android/extensions-compose-experimental.api
- extensions-compose-experimental/api/extensions-compose-experimental.klib.api

Summary by CodeRabbit
New Features
Bug Fixes
Chores