feat: add keep_values_formatting for values of parameter#145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parameters that define a fixed set of allowed values currently normalize each value's display label to sentence case, forcing the first letter to uppercase and the rest to lowercase. This is applied automatically, so labels like "iPhone", "USB-C" or "già pagato" are rewritten to "Iphone", "Usb-c" and "Già pagato", with no way to keep the label exactly as authored.
This PR introduces a new boolean option,
keep_values_formatting, on parameters that support values. When enabled, the value labels are stored and returned exactly as provided, preserving the original casing and formatting.Behavior
The option is fully backward compatible: parameters that don't set it fall back to the current default behavior.