Add public_dir configuration to build settings#9
Conversation
Point build.public_dir at the existing public/ directory so the assets referenced by logo:/seo: (favicon, og-image, …) ship with the build and override gomark's bundled defaults instead of 404'ing. Requires a gomark release that includes the public_dir overlay; bump the CLI pin in the Dockerfile once that release is tagged.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s gomark.yaml build configuration by adding a public_dir setting intended to define a dedicated directory for static/public assets during the gomark build process.
Changes:
- Add
build.public_dir: publicto the gomark YAML configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| build: | ||
| content_dir: content | ||
| output_dir: /out/site | ||
| public_dir: public |
There was a problem hiding this comment.
Correct, and intentional. public_dir is the new asset-overlay option added in arivictor/gomark#9; it's inert on v0.1.14 but harmless (unknown YAML keys are ignored, not errors). This field is staged here so the config is ready. It takes effect once gomark#9 is merged and tagged, and the Dockerfile pin here is bumped to that release — that bump will land as a follow-up commit on this PR.
Generated by Claude Code
Summary
Added a new
public_dirconfiguration option to the build settings in the gomark configuration file.Changes
public_dir: publicto the build configuration section, specifying the public directory for the static site build outputDetails
This configuration parameter allows users to define a dedicated public directory for the build process, complementing the existing
content_dirandoutput_dirsettings. This is useful for organizing static assets and public-facing files separately from the main output directory.https://claude.ai/code/session_018hwJ3xsqpbPzapfdRnv2Ny