Remove reader mode and hardcoded /go/ link stripping#24
Merged
Conversation
The framework originally served a site rooted at /go/<topic>, so markdown link normalization special-cased "/go/" by rewriting it to "/". That site layout is no longer used, and the hardcoded prefix silently broke any legitimate links to a top-level /go/ path. Treat absolute links as-is. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes legacy URL-rewriting behavior and updates related documentation/tests so that absolute markdown links (including /go/...) are preserved as-is, reflecting the current site layout.
Changes:
- Updated
buildRoutePathcomment and its unit test cases to match actual behavior (slug → absolute route, no special/gohandling implied). - Removed the hardcoded
/go/prefix stripping fromnormalizeLinkTarget. - Adjusted markdown renderer tests to align with the new absolute-link preservation behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
site_url.go |
Corrects buildRoutePath comment to accurately describe slug→route behavior. |
site_url_test.go |
Updates TestBuildRoutePath cases to match the function’s actual trimming/normalization behavior. |
site_markdown.go |
Removes the special-case rewrite that stripped /go/ from absolute link targets. |
site_markdown_test.go |
Updates renderer emphasis tests to use non-/go/ absolute links consistent with new normalization rules. |
site_markdown_inline_test.go |
Updates normalizeLinkTarget expectations to ensure absolute /go/... paths are preserved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two cleanups of legacy, no-longer-needed behavior:
/go/link prefix stripping —normalizeLinkTargetpreviously rewrote any markdown link starting with/go/to/, a leftover from when the framework served a site rooted at/go/<topic>.Why
The
/go/rewrite was a brittle, hardcoded special case. That site layout is no longer used, and the prefix silently broke any legitimate link to a top-level/go/...path. Absolute links are now passed through as-is.Reviewer notes
buildRoutePathinsite_url.gowas corrected (it never actually strippedgo).🤖 Generated with Claude Code