Remove reader/focus mode feature#23
Merged
Merged
Conversation
Reader mode (the "focus mode" toggle that hid navigation to show only page content) was a redundant feature. This removes its CSS, the TOC toggle button, the floating exit control, the supporting JS, the template test, and the related documentation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes the reader/focus mode UI and behavior from the default site layout, and updates tests and documentation to match.
Changes:
- Deleted reader/focus mode CSS, controls, and localStorage-backed toggle logic from the main HTML layout template.
- Removed the layout test that asserted the presence of focus mode controls.
- Updated navigation documentation to remove mention of the reader/focus mode toggle, and bumped the docs Docker image’s installed gomark CLI version.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/layout.html | Removes reader/focus mode styles, UI controls, and toggle JavaScript. |
| site_template_nav_test.go | Drops the test that validated rendering of focus mode controls. |
| docs/getting-started/navigation.md | Removes documentation describing the reader/focus mode toggle. |
| docs/Dockerfile | Bumps the pinned gomark CLI version used to build the docs image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes the reader/focus mode feature (the "Reader mode" toggle that hid the header, sidebar, and TOC to show only page content).
.focus-exit/html[data-focus-mode]CSS, the floating "Exit Reader Mode" button, the "Reader mode" toggle in the TOC tools, and the JS handling the toggle and its localStorage persistence.TestLayoutRendersFocusModeControls.Why
The feature was redundant.
Notes for reviewers
go build ./...and the layout tests pass. Remainingreaderreferences in the codebase are unrelated (io.Reader, "readers" as audience, etc.).🤖 Generated with Claude Code