Record the enums found in all proto files for later access#3
Open
gingerbus wants to merge 1 commit into
Open
Conversation
Allow access to the per-imported proto oracles to allow validation of enum keys outside of the protobuf being parsed. Code which relies on this library can only validate the enums parsed in the targeted proto file. By exposing the enums found in the imported proto files we can extend the validation to the set of all enums found during the parse.
Author
|
@zmarcantel Gentle reminder... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tooling we use internally requires that we can validate against enums found not just in the current proto file, but also in imported proto files. If we retain the oracles generated during parse time for all proto files, we can refer back to them at a later validation time in our code to ensure the externally referred-to enum exists somewhere in the file dependencies.
Added a test to show the usage.