Recursive verifier#440
Open
gabriel-barrett wants to merge 28 commits into
Open
Conversation
reduces width significantly
| @@ -0,0 +1,201 @@ | |||
| import Ix.Aiur.Meta | |||
Member
There was a problem hiding this comment.
This file seems to be a smoke test for the recursive verifier.
I think testing should be properly integrated in the test suite.
| lean-ffi = { git = "https://github.com/argumentcomputer/lean-ffi", rev = "cc98ebf67bf453ac3827cb767f78b13ea674dd6a" } | ||
| mimalloc = { version = "0.1", default-features = false } | ||
| multi-stark = { git = "https://github.com/argumentcomputer/multi-stark.git", rev = "9ecab51d553445c0cc7b571af00a76b8a83a6f8c" } | ||
| multi-stark = { path = "multi-stark" } |
Member
There was a problem hiding this comment.
This change needs to be undone.
Comment on lines
+56
to
+58
| enum Commitments { | ||
| Mk(MerkleCap, MerkleCap, MerkleCap) | ||
| } |
Member
There was a problem hiding this comment.
Seeing these single-constructor enums gave me the idea: they don't need tags in the bytecode and should be treated as simple tuples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the recursive verifier, that is, multi-stark in Aiur, including Plonky3's PCS verifier.
Currently it assumes values of a few parameters:
capHeight = 0, meaning commitments are a single digest. Cap height decides how deep into the merkle tree the commitment is. A greater cap height means the commitment themselves are larger, but it saves on the openings.maxLogArity = 1, meaning FRI uses arity 2 fold.queryProofOfWork = 0, meaning there's no proof of work before the sampling of query indicesEventually we could generalize it to accept other values for
capHeightandqueryProofOfWork. This is mostly for proof size. RegardingmaxLogArity, it might not be worth it generalizing it, since arity 2 is pretty standard