Add assertApproxEqRel cheatcode (uint256 and int256)#1067
Open
gustavo-grieco wants to merge 1 commit into
Open
Add assertApproxEqRel cheatcode (uint256 and int256)#1067gustavo-grieco wants to merge 1 commit into
gustavo-grieco wants to merge 1 commit into
Conversation
Implement foundry's assertApproxEqRel as a native hevm cheatcode, mirroring the existing assertApproxEqAbs. The relative percent delta is computed as |a - b| * 1e18 / b (denominator is the second/reference argument; 1e18 == 100%), and the assertion passes when percentDelta <= maxPercentDelta. Matches foundry's native cheatcode semantics: - int256 delta accounts for signs (same sign: ||a|-|b||, opposite: |a|+|b|), denominator is |b| - b == 0 && a == 0 -> pass; b == 0 && a != 0 -> fail with "real delta: undefined" - concrete path computes in arbitrary-precision Integer to avoid the intermediate overflow foundry sidesteps with U512 - best-effort symbolic path Adds pass/fail test contracts and FoundryTests entries. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement foundry's assertApproxEqRel as a native hevm cheatcode, mirroring the existing assertApproxEqAbs. The relative percent delta is computed as |a - b| * 1e18 / b (denominator is the second/reference argument; 1e18 == 100%), and the assertion passes when percentDelta <= maxPercentDelta.
Matches foundry's native cheatcode semantics:
Adds pass/fail test contracts and FoundryTests entries.
Description
Checklist