Resolve conflicts in src/bin/pg_rewind/filemap.c#2598
Open
RekGRpth wants to merge 1 commit into
Open
Conversation
1) Commit f81e97d in src/bin/pg_rewind/filemap.c removed the definitions of the path_cmp and get_filemap_entry functions and added definitions of the new insert_filehash_entry and lookup_filehash_entry functions. However, the earlier commit 1a770cf had already added the definition of get_filemap_entry. 2) Commit f81e97d in src/bin/pg_rewind/filemap.c refactored the process_source_file function, which had already been modified by earlier commits. 3) Commit f81e97d in src/bin/pg_rewind/filemap.c refactored the process_target_file function, which had already been modified by earlier commits. 4) Commit f81e97d in src/bin/pg_rewind/filemap.c refactored the code in the process_target_wal_block_change function, although earlier commits had already changed it. 5) Commit f81e97d in src/bin/pg_rewind/filemap.c removed the filemap_list_to_array function, and commit eb00f1d removed the filemap_finalize function, although earlier commit 1a770cf had already partially done the same. 6) Commit f81e97d in src/bin/pg_rewind/filemap.c in the calculate_totals function replaced the local variable filemap_t *map with the argument filemap_t *filemap, although earlier commit 1a770cf had already changed this code. 7) Commit eb00f1d added a new function, decide_file_action, to src/bin/pg_rewind/filemap.c. Earlier commit 1a770cf had already done the same, but added handling for the FILE_TYPE_FIFO case and setting the is_gp_tablespace field. 8) Commit eb00f1d added a new function, decide_file_actions, to src/bin/pg_rewind/filemap.c. Commit f81e97d refactored its contents, changing its return type from void to filemap_t *, and added a new function, hash_string_pointer. Earlier commit 1a770cf had already partially done the same.
silent-observer
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f81e97d in src/bin/pg_rewind/filemap.c removed the
definitions of the path_cmp and get_filemap_entry functions and added
definitions of the new insert_filehash_entry and lookup_filehash_entry
functions. However, the earlier commit 1a770cf had already added the
definition of get_filemap_entry.
Commit f81e97d in src/bin/pg_rewind/filemap.c refactored the
process_source_file function, which had already been modified by
earlier commits.
Commit f81e97d in src/bin/pg_rewind/filemap.c refactored the
process_target_file function, which had already been modified by
earlier commits.
Commit f81e97d in src/bin/pg_rewind/filemap.c refactored the code in
the process_target_wal_block_change function, although earlier commits
had already changed it.
Commit f81e97d in src/bin/pg_rewind/filemap.c removed the
filemap_list_to_array function, and commit eb00f1d removed the
filemap_finalize function, although earlier commit 1a770cf had already
partially done the same.
Commit f81e97d in src/bin/pg_rewind/filemap.c in the
calculate_totals function replaced the local variable filemap_t *map
with the argument filemap_t *filemap, although earlier commit 1a770cf
had already changed this code.
Commit eb00f1d added a new function, decide_file_action, to
src/bin/pg_rewind/filemap.c. Earlier commit 1a770cf had already done
the same, but added handling for the FILE_TYPE_FIFO case and setting
the is_gp_tablespace field.
Commit eb00f1d added a new function, decide_file_actions, to
src/bin/pg_rewind/filemap.c. Commit f81e97d refactored its contents,
changing its return type from void to filemap_t *, and added a new
function, hash_string_pointer. Earlier commit 1a770cf had already
partially done the same.