Resolve conflicts in pg_backup.h, pg_backup_db.c, and pg_backup_archiver.c#2595
Open
RekGRpth wants to merge 2 commits into
Open
Resolve conflicts in pg_backup.h, pg_backup_db.c, and pg_backup_archiver.c#2595RekGRpth wants to merge 2 commits into
RekGRpth wants to merge 2 commits into
Conversation
…ver.c 1) Commit a45bc8a in src/bin/pg_dump/pg_backup.h added the definition of the new ConnParams structure, while earlier commit 3040b44 had already done the same, adding the definition of the new _dumpPreparedQueries enumeration above. 2) Commit a45bc8a in src/bin/pg_dump/pg_backup.h changed the arguments in the ConnectDatabase function definition, while earlier commit 19cd1cf had already added the new bool binary_upgrade argument. 3) Commit 257836a added a new field, coll_unknown, to the DumpOptions structure in src/bin/pg_dump/pg_backup.h, while an earlier commit, 77cd915, had already added the GPDB-specific fields, dumpGpPolicy and isGPbackend, in the same location. 4) Commit a45bc8a removed the declaration of the _connectDB function in src/bin/pg_dump/pg_backup_db.c, while an earlier commit, 8ae22d1, had already added pg_attribute_unused to the notice_processor function argument below. 5) Commit a45bc8a in src/bin/pg_dump/pg_backup_db.c refactored the code, including arguments, in the ConnectDatabase function. However, the earlier commit 19cd1cf had already added the new bool binary_upgrade argument and its handling. 6) Commit a45bc8a in src/bin/pg_dump/pg_backup_archiver.c in the RestoreArchive function changed the call to the ConnectDatabase function. However, the earlier commit 19cd1cf had already added the new bool binary_upgrade argument to the ConnectDatabase function. 7) Commit a45bc8a in src/bin/pg_dump/pg_backup_archiver.c changed the call to the ConnectDatabase function in the restore_toc_entries_postfork function, while the earlier commit 19cd1cf had already added a new bool binary_upgrade argument to the ConnectDatabase function. 8) Commit a45bc8a in src/bin/pg_dump/pg_backup_archiver.c simplified the code in the CloneArchive function, while the earlier commit 19cd1cf had already added a new bool binary_upgrade argument to the ConnectDatabase function.
silent-observer
approved these changes
May 26, 2026
KnightMurloc
approved these changes
May 29, 2026
silent-observer
approved these changes
May 29, 2026
KnightMurloc
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a45bc8a in src/bin/pg_dump/pg_backup.h added the definition
of the new ConnParams structure, while earlier commit 3040b44 had
already done the same, adding the definition of the new
_dumpPreparedQueries enumeration above.
Commit a45bc8a in src/bin/pg_dump/pg_backup.h changed the arguments
in the ConnectDatabase function definition, while earlier commit
19cd1cf had already added the new bool binary_upgrade argument.
Commit 257836a added a new field, coll_unknown, to the DumpOptions
structure in src/bin/pg_dump/pg_backup.h, while an earlier commit,
77cd915, had already added the GPDB-specific fields, dumpGpPolicy and
isGPbackend, in the same location.
Commit a45bc8a removed the declaration of the _connectDB function in
src/bin/pg_dump/pg_backup_db.c, while an earlier commit, 8ae22d1,
had already added pg_attribute_unused to the notice_processor function
argument below.
Commit a45bc8a in src/bin/pg_dump/pg_backup_db.c refactored the
code, including arguments, in the ConnectDatabase function. However,
the earlier commit 19cd1cf had already added the new bool
binary_upgrade argument and its handling.
Commit a45bc8a in src/bin/pg_dump/pg_backup_archiver.c in the
RestoreArchive function changed the call to the ConnectDatabase
function. However, the earlier commit 19cd1cf had already added the new
bool binary_upgrade argument to the ConnectDatabase function.
Commit a45bc8a in src/bin/pg_dump/pg_backup_archiver.c changed the
call to the ConnectDatabase function in the
restore_toc_entries_postfork function, while the earlier commit 19cd1cf
had already added a new bool binary_upgrade argument to the
ConnectDatabase function.
Commit a45bc8a in src/bin/pg_dump/pg_backup_archiver.c simplified
the code in the CloneArchive function, while the earlier commit 19cd1cf
had already added a new bool binary_upgrade argument to the
ConnectDatabase function.