Skip to content

Moving a sketch to another folder should move all files#6404

Closed
facchinm wants to merge 1 commit into
arduino:masterfrom
facchinm:movesketch_partial
Closed

Moving a sketch to another folder should move all files#6404
facchinm wants to merge 1 commit into
arduino:masterfrom
facchinm:movesketch_partial

Conversation

@facchinm

Copy link
Copy Markdown
Member

Fixes #6402

@ArduinoBot

Copy link
Copy Markdown
Contributor

@per1234

per1234 commented Jun 24, 2017

Copy link
Copy Markdown
Collaborator

I just wanted to comment that, even if this PR doesn't fix #6402, it is a useful improvement. The previous behavior of only moving the primary sketch file regularly caused problems for people who downloaded a multi-file sketch from GitHub when that sketch is in the root of the repository. GitHub appends the branch name to the sketch folder, which forces the move, and breaks the sketch.

Example of the previous behavior causing problems: Espressobar/arduino-grind-timer#2

@facchinm facchinm added this to the Release 1.8.4 milestone Jul 25, 2017
@facchinm facchinm modified the milestones: Release 1.8.4, Next Aug 18, 2017
@ArduinoBot

Copy link
Copy Markdown
Contributor

@cmaglie

cmaglie commented Aug 23, 2018

Copy link
Copy Markdown
Member

We are searching a better solution for this problem, for now the commit has been reverted.
Follow ups on #7909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants