[BREAKING] Fix inverted logic in canRunOnBattery #38#62
Open
a-27m wants to merge 1 commit into
Open
Conversation
The examples are updated accordingly
|
Memory usage change @ 2cb38ee
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double checked the datasheet and tested with the MKR1010 to confirm.
The examples are updated accordingly.
Despite this being a bug, given its been years, I tend to consider this a breaking change.
I would appreciate help making this as prominent as we can for the folks who just dealt with the erroneous inversion in their code already.