Dimo sdk 1.8.0#267
Merged
Merged
Conversation
Added comprehensive test cases for `DimoSensorEntity` and `DimoVehicleSensorEntity` including value formatting, unit mapping, and error handling for missing values.
Update dimo-python-sdk dependency from 1.6.0 to 1.8.0 in both the integration manifest and test requirements.
There was a problem hiding this comment.
Pull request overview
This PR updates the DIMO Home Assistant integration to use dimo-python-sdk==1.8.0 and adds unit tests covering the sensor entity value/unit extraction logic.
Changes:
- Bump
dimo-python-sdkfrom1.6.0to1.8.0in the integration manifest and test requirements. - Add
tests/test_sensor.pyvalidatingDimoSensorEntity/DimoVehicleSensorEntitynative value and unit behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/test_sensor.py |
Adds coverage for sensor entity native_value / native_unit_of_measurement behavior. |
requirements_test.txt |
Updates pinned SDK version used in the test environment. |
custom_components/dimo/manifest.json |
Updates runtime dependency pin for the integration to SDK 1.8.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.