refactor: combine signal retrieval and token rewards operations.#264
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the signal retrieval and token rewards operations to execute concurrently using asyncio.gather, improving performance by fetching both datasets in parallel. The _update_token_rewards async method is converted to a synchronous _process_token_rewards method that processes pre-fetched data rather than fetching it itself.
Changes:
- Combined signal and token rewards API calls to execute concurrently using
asyncio.gather - Refactored
_update_token_rewardsfrom async method to sync_process_token_rewardsthat processes already-fetched data - Minor code quality improvements in
dimo_client.pyto avoid redundant dictionary access
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| custom_components/dimo/init.py | Refactored to fetch signals and rewards concurrently; converted _update_token_rewards to sync _process_token_rewards method |
| custom_components/dimo/dimoapi/dimo_client.py | Minor refactoring to eliminate redundant dictionary access and improve code readability |
| tests/test_init.py | Updated test to reflect sync nature of _process_token_rewards; removed async decorator and updated mocking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




No description provided.