Skip to content

Add ArchitecturyPluginExtension.fromCommon#44

Draft
Juuxel wants to merge 5 commits into
architectury:3.4from
Juuxel:feature/helpers
Draft

Add ArchitecturyPluginExtension.fromCommon#44
Juuxel wants to merge 5 commits into
architectury:3.4from
Juuxel:feature/helpers

Conversation

@Juuxel

@Juuxel Juuxel commented Mar 2, 2024

Copy link
Copy Markdown
Member

Basic usage example:

architectury {
    // Sets up dev dependencies and production jar bundling as a one-liner.
    fromCommon ':common'
}

More complicated usage example from Arch API: Juuxel/architectury-api@39de89c

Note about the version: this isn't a breaking change, but it's a good chance to introduce some cleanup breaking changes, like removing unused properties and simplifying the extension class.

if (commonDevDep is ModuleDependency) {
commonDevDep.isTransitive = false
}
project.dependencies.add(JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME, commonDevDep)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Check how this publishes. Using namedElements over the default config should prevent it from appearing in the POM though

@rhysdh540

Copy link
Copy Markdown

question-why make this in java instead of kotlin like the rest of the plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants