test: drop @hapi/teamwork by re-architecting tests around inject()'s return value#271
Merged
Conversation
…return value The deferred pattern was only there to bridge a callback-style inject() back into await. Returning the response (and capturing post-celebrate `req` via a closure where needed) removes the need for a callback at all. Refs #257. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 263 263
=========================================
Hits 263 263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
@hapi/teamwork).inject()returns its response, tests no longer need a callback adapter.Refs #257.
QA Spec
npm testpasses on Node 20, 22, 24, 25npx eslint .clean@hapi/teamworkis gone from package.jsonMade with Cursor