fix(cdp): keep default raw readiness best effort - #310
Conversation
|
I have everything I need. Here is the full review. PR #310 — fix(cdp): keep default raw readiness best effortScope: 1. DeterminismNo violations. The change touches only CDP I/O orchestration; nothing flows into 2. Workspace layeringClean. All changes stay inside 3. Error handlingThe semantic split is sound:
4. Test coverageThe two renamed unit tests ( 5. DocumentationAll modified/added functions are private. Punch listNo blockers or warnings found. The change is a minimal, well-scoped behavioural fix with the semantics clearly encoded in the function names and the log message. Verdict: APPROVE |
Summary
--wait-forselectors strictbodyreadiness probe best-effort before DOM snapshot capturewait_for_selector "body"exhausted its 10s budget after a page-init stallValidation
cargo fmt --all -- --checkcargo test -p plumb-cdp --lib raw_cargo clippy -p plumb-cdp -p plumb-cli --all-targets --all-features -- -D warningscargo build --release -p plumb-clicargo run --release -p plumb-e2e -- --site html-css --site tailwind-html --site react-vite --no-build --plumb-bin target/release/plumb --chrome-path "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"