chore: post-merge cleanups (release-prep deletion + npm Windows ARM64 strip) - #287
Merged
Conversation
PR #276 had to revert the deletion of docs/src/ci/release-prep.md because tests/install-smoke-validate.sh greps the file for "Issue #51 verified" and "Issue #52 wired" sentinel strings. Those issues are now resolved (Homebrew tap and unscoped npm publish both ship as of 0.0.10/0.0.11), so the doc page is internal noise that doesn't belong in the public book. This commit removes both the page (already deleted via git rm in the same working tree) and the guard that referenced it.
cargo-dist 0.28.0 emits an aarch64-pc-windows-msvc entry in the npm package's supportedPlatforms that points to the x86_64 Windows zip. On Windows ARM that silently installs the wrong arch. The npm-publish job now extracts the tarball, removes the bad mapping from package.json via a node one-liner, repacks, and publishes. When cargo-dist ships a filter knob or we add a real Windows ARM64 target, the strip step can come out. Closes audit finding H7.
Contributor
|
I have all the information needed. Here is the full review. PR #286 — chore(main): release 0.0.12Type: Release-please automation. No Rust source changes. 1. DeterminismNot applicable — no Rust code touched. 2. Workspace layeringNot applicable — no Rust code touched. 3. Error handlingNot applicable — no Rust code touched. 4. Test coverageNot applicable — no new API surface. 5. Documentation (CHANGELOG correctness)All Cargo.toml integrity
Punch listNo findings. Verdict: APPROVE |
6 tasks
aram-devdocs
added a commit
that referenced
this pull request
May 12, 2026
…292) * fix(ci): unstick Preflight + tolerate Dogfood warnings/nextjs flake PR #287 deleted docs/src/ci/release-prep.md and removed the matching guard in tests/install-smoke-validate.sh, but missed the parallel guard in tests/release-security-validate.sh. The validator has been failing on every CI run since 2026-05-07, skipping every downstream job (MSRV, deny, Test, Size, Coverage, Determinism, Docs). Drop the stale RELEASE_PREP_DOC declaration and the corresponding sentinel-grep block. The Homebrew + npm contracts are still validated authoritatively against dist-workspace.toml and install-smoke.yml in sections 5 and 6 of the same script. Two follow-on dogfood fixes since the daily run has been red since 2026-05-02 (after the Phase 7 rule additions in #202/#204/#207): - lint-canonical-docs now tolerates exit 3 (warnings/info only) alongside exit 0, mirroring the test-sites leg in the same workflow. Errors still fail. The 318-violation steady state on the live docs site is a separate content/theme cleanup, not a CI bug. - nextjs leg gets continue-on-error on both plumb invocations to mirror the e2e-sites stance on the upstream chromiumoxide WebSocket flake tracked in #233. Also drops the dead docs/src/ci/release-prep.md reference from the install-smoke.yml header comment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(cdp): gate macos_candidate ordering test to unix The `macos_candidate_order_lists_system_apps_then_user_apps` test in crates/plumb-cdp/src/chrome_path.rs asserts that paths returned by `macos_candidates` start with `/Users/example/Applications/...` — forward slashes against `Path::display()`. On Windows, `Path::join` uses `\`, so display[3] becomes `/Users/example\Applications\Google Chrome.app\...` and the starts_with check fails. `detect_with` short-circuits to `None` on non-macOS targets, so the function is never reached in production on Windows. Gate the test to `#[cfg(unix)]` to keep the existing Linux coverage and drop the unreachable Windows leg. This test was previously masked because Preflight has been failing on every CI run since 2026-05-07, which skipped Test (windows-latest) entirely. Surfacing now as a side effect of the validator fix in this same PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(cdp): gate macos_candidates import to unix in tests Follow-up to 890b14c. Gating the test to `#[cfg(unix)]` left `macos_candidates` as an unused import on Windows, breaking the `Test (windows-latest)` build with `error: unused import: \`macos_candidates\``. Mirror the gate on the import. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small cleanups that emerged from the share-readiness audit's merge train:
Re-delete
docs/src/ci/release-prep.mdand drop the deadinstall-smoke-validate.shguard that greps it. PR docs: remove stale blog, complete config reference, sweep dead PRD refs #276 had to revert the deletion when this guard surprised it.Strip wrong-arch
aarch64-pc-windows-msvcmapping from the npm tarball beforenpm publish. cargo-dist 0.28.0 has no knob to filtersupportedPlatforms, and PR docs(cli): npm-first README + flag wrong-arch Windows ARM64 mapping #277 documented the gap but couldn't fix the publish job. Closes audit finding H7.Why
Both items were planned but deferred during the parallel Wave A dispatch to avoid scope creep on their parent PRs.
Test plan
tests/install-smoke-validate.shpasses after the guard removal.npm view plumb-cli supportedPlatformsdoes not includeaarch64-pc-windows-msvc.🤖 Generated with Claude Code