Skip to content

test: v3 autonomous full-flow proof - #149

Merged
aram-devdocs merged 1 commit into
mainfrom
test/issue-148-v3-autonomous-full-flow-proof
Apr 29, 2026
Merged

test: v3 autonomous full-flow proof#149
aram-devdocs merged 1 commit into
mainfrom
test/issue-148-v3-autonomous-full-flow-proof

Conversation

@aram-devdocs

Copy link
Copy Markdown
Owner

Closes #148

Verification:

  • git diff --stat shows CHANGELOG.md | 1 +.
  • git diff -- CHANGELOG.md shows only the new - v3 autonomous full-flow proof bullet under ## [Unreleased].
  • Confirmed the new bullet appears exactly once under Unreleased and no released changelog sections changed.

@github-actions

Copy link
Copy Markdown
Contributor

I have enough context. Let me draft the review.


Code review summary

PR: #149 — "test: v3 autonomous full-flow proof"
Author: aram-devdocs
Base: main → CHANGELOG.md only (+1 line)


Blockers

# Severity File Line Issue Suggestion
None

Warnings

# Severity File Line Issue Suggestion
1 Warning CHANGELOG.md 13 Changelog entry is not user-visible. AGENTS.md / CLAUDE.md: "Update the CHANGELOG under ## [Unreleased] only for user-visible changes." "v3 autonomous full-flow proof" is an internal CI/test validation artifact, not a feature or fix a user would encounter. Remove the entry, or replace it with a user-facing description of whatever user-visible behavior was proved (e.g. a concrete feature bullet).
2 Warning CHANGELOG.md 14 The preceding entry "v3 ACP-allowed proof" (merged via #147) carries the same problem — also not user-visible. This PR doubles down on a pattern that was already in tension with project policy. Both bullets should be removed or rewritten before this section is released.
3 Warning commit type PR title is test: (Conventional Commits). The CHANGELOG header states this file is auto-maintained by release-please based on CC from PR #3 onward; test: commits intentionally don't produce release notes. Manually adding a changelog entry for a test: commit bypasses that intent. If the automation should generate the note, use feat: or fix: with a meaningful description. If it's truly a test: commit, don't touch the changelog.

Architecture compliance

  • [✅] No new unsafe outside plumb-cdp
  • [✅] No new unwrap / expect / panic! in library crates
  • [✅] No new println! / eprintln! outside plumb-cli
  • [✅] No new wall-clock or HashMap in observable-output paths
  • [✅] No new todo! / unimplemented! / dbg!

Anti-pattern scan

Pattern Status Details
Non-user-visible changelog entry ⚠️ CHANGELOG.md:13 — internal test/proof language
release-please automation bypass ⚠️ Manual edit for a test: commit type
Commented-out code / dead code None
docs/src humanizer check Not applicable (CHANGELOG.md ≠ docs/src/)

Quality assessment

The diff is one line in CHANGELOG.md. There are no Rust, safety, determinism, or layering concerns. The sole issue is policy: the project's documented rule restricts ## [Unreleased] additions to user-visible changes, and "v3 autonomous full-flow proof" describes an internal test automation exercise, not user-observable product behavior. The compound effect with the already-merged "v3 ACP-allowed proof" bullet means two consecutive entries in Unreleased are internal noise that will end up in a release note.

Scope check

  • Changes match PR description: ✅ (description accurately describes the single-line diff)
  • Scope creep detected: No

Punch list

  • CHANGELOG.md:13 — Remove or replace "v3 autonomous full-flow proof" with a user-facing description (or omit entirely for a test: commit).
  • CHANGELOG.md:14 — "v3 ACP-allowed proof" from test: v3 ACP-allowed proof #147 has the same violation; clean up both in one pass before the next release cut so they don't land in release notes.
  • Align the PR commit type (test:) with changelog practice: either use a feat:/fix: type with a real user description, or don't edit the changelog for test: commits.

Verdict: REQUEST_CHANGES

@aram-devdocs
aram-devdocs merged commit 07662bf into main Apr 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: v3 autonomous full-flow proof

1 participant