Skip to content

docs: retarget phase 1 acceptance criterion to checked-in fixture #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aram-devdocs merged 1 commit into from
Apr 25, 2026
Merged

docs: retarget phase 1 acceptance criterion to checked-in fixture #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions docs/runbooks/phase-1-spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ parent:
extension follows: Rule trait + golden test + docs page +
register_builtin; Chromium launch + DOMSnapshot + viewport multi-run.
acceptance_criteria:
- "`plumb lint https://plumb.aramhammoudeh.com --format json` renders a real page via Chromium and emits ≥1 violation from a real rule."
- "`plumb lint file://$REPO/crates/plumb-cdp/tests/fixtures/static_page.html --format json` (with `$REPO` resolved to an absolute path) renders the checked-in fixture via Chromium and emits ≥1 violation from a real rule. The fixture's `padding:13px` on `<body>` is off-grid against the default `spacing.base_unit = 4`, so `spacing/grid-conformance` fires deterministically. (Phase 6 (#56) will additionally enable `https://plumb.aramhammoudeh.com` as an acceptance target once the docs site ships.)"
- "3x byte-diff determinism check holds on the new rules (`just determinism-check`)."
- "`cargo xtask pre-release` green — rule docs in sync, schema current."
- "All 9 child PRs merged."
Expand Down Expand Up @@ -188,8 +188,11 @@ batches:

phase_gate:
criterion: |
`just validate` green AND `plumb lint https://plumb.aramhammoudeh.com --format json`
renders a real page via Chromium and emits ≥1 violation from a real
rule AND `just determinism-check` passes on the new rules AND
`just validate` green AND `plumb lint file://$REPO/crates/plumb-cdp/tests/fixtures/static_page.html --format json`
(with `$REPO` resolved to an absolute path) renders the checked-in
fixture via Chromium and emits ≥1 violation from a real rule AND
`just determinism-check` passes on the new rules AND
`cargo xtask pre-release` passes (rule docs in sync, schema current).
The docs-site URL `https://plumb.aramhammoudeh.com` becomes an
additional valid target in Phase 6 (#56) once the site ships.
unblocks: "phase-2"