fix(ci): add missing libudev-dev to docs, skip GPU smoke in CI - #666
Conversation
…t in CI Deploy Docs failed on every push to main because docs.yml was missing libudev-dev (and libxkbcommon-x11-dev) from its apt-get install line. CI workflow failed because native_main_thread GPU smoke test cannot run in headless CI environments on macOS/Windows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Claude finished @aram-devdocs's task in 36s —— View job PR Review: fix(ci): add missing libudev-dev to docs, skip GPU smoke in CI
Verdict: ✅ APPROVEDThis is a clean, minimal CI infrastructure fix. No blockers, no warnings. Phase 1–2: Context & ArchitectureBoth changed files are CI/test infrastructure only. No engine layers, FFI, or SDK code is touched — architecture validation is not applicable. Phase 3–4: Anti-Pattern & Quality Assessment
The fix adds
fn should_skip_native_smoke() -> bool {
if std::env::var_os("CI").is_some() {
return true;
}
// ...
}The early-return on One minor observation (non-blocking): the skip message says "no display available" even when the actual skip reason is Phase 6: Scope Verification
Positive Callouts
|
Summary
docs.ymlwas missinglibudev-dev(andlibxkbcommon-x11-dev) from its system dependencies — thelibudev-syscrate panicked at build timenative_main_threadGPU smoke test runs on macOS/Windows CI runners that lack a real GPU — now skipped whenCI=trueTest plan
rust-checkjob passes on all platforms (Ubuntu/macOS/Windows)native_main_threadtest still runs locally with a real display (cargo test -p goud-engine-core --test native_main_thread)🤖 Generated with Claude Code